Reimplement pipecleaner.py in Go #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not use this feature, so we can remove it Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
We do not use this feature So we can remove it Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
We don't use python anywhere else, and python 2 is going EOL soon Rewrite this in Go so that we can use this everywhere Additionally we can "go install" it to share it between repos Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk> Co-authored-by: Sebastian <sebastian.schmieschek@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
added 4 commits
December 23, 2019 15:25
gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen gimme gimme gimme go thirteen Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
tlwr
pushed a commit
that referenced
this pull request
Dec 23, 2019
Reimplement pipecleaner.py in Go
This was referenced Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replaces a python2 based pipecleaner with a Go binary
Adds more tests to pipecleaner
Adds rubocop functionality to pipecleaner
Adds
fly validate-pipeline-esque functionality to pipecleanerUse pipecleaner in our pipeline
Running pipecleaner in our repo
Running pipecleaner against the fixtures
Who can review
@schmie and I mostly paired on this