[#184537961] Moved personal static ips to paas-trusted-people #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
4 times, most recently
from
52d9bb9
to
b2faea5
Compare
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
from
b2faea5
to
47e6cc8
Compare
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
from
47e6cc8
to
7cc5198
Compare
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
6 times, most recently
from
d54c072
to
9602d5e
Compare
muzakh
approved these changes
May 10, 2023
whi-tw
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
2 times, most recently
from
f2de838
to
b167482
Compare
|
Rebased against main |
whi-tw
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
from
b167482
to
668281a
Compare
whi-tw
approved these changes
May 22, 2023
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
from
668281a
to
ef51a71
Compare
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
from
ef51a71
to
f22cf73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moved personal static ips from paas-aws-account-wide-terraform, paas-bootstrap and paas-cf as required by this pivotal tracker storey. Made related changes to paas-aws-account-wide-terraform, paas-bootstrap and paas-trusted-people repos.
How to review
Run this branch into a dev env.
Ensure that the PAAS_TRUSTED_PEOPLE_BRANCH var is set to the related branch in the paas-trusted-people repo before uploading the secrets.
Ensure that you have the connectivity to the dev env that you had previously.
Who can review
Anyone with a static ip in the paas-trusted-people repository.
馃毃鈿狅笍 Please do not merge this pull request via the GitHub UI 鈿狅笍 馃毃