[#184537961] Get personal static ips from paas-trusted-people #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
4 times, most recently
from
90085c0
to
0cf2fe7
Compare
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
2 times, most recently
from
f3d6a0b
to
0d96bb7
Compare
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
5 times, most recently
from
93a6b80
to
f065014
Compare
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
2 times, most recently
from
3f0bd57
to
79e7e80
Compare
whi-tw
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
2 times, most recently
from
841eea5
to
0b9fb33
Compare
|
Rebased against main |
whi-tw
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
from
0b9fb33
to
774d6a9
Compare
whi-tw
approved these changes
May 22, 2023
malcgds
force-pushed
the
184537961-mv-personal-ips-from-repos
branch
from
774d6a9
to
849f314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes for pivotal tracker storey. Made related changes to paas-cf, paas-trusted-people and paas-aws-account-wide-terraform repos.
How to review
The new procedure for testing changes to paas-bootstrap is to run the branch into a new bootstrap environment.
Ensure that the PAAS_TRUSTED_PEOPLE_BRANCH var is set to the related branch in the paas-trusted-people repo before uploading the secrets.
Once the terraform jobs have completed check that you have the same access to the system components as you had before.
The expunge-concourse concourse job should not remove the user_static_cidrs from the security groups.
Who can review
The change should be tested by anyone with a current static ip address exposed in paas-cf and paas-bootstrap.
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨