[#184917692] Remove AWS vpns #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcgds
changed the title
risicle
reviewed
May 17, 2023
risicle
reviewed
May 17, 2023
malcgds
force-pushed
the
184917692-remove-aws-vpns
branch
from
5a7adc0
to
129c121
Compare
risicle
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The changes are associated with pivotal tracker ticket 184917692. The configuration has been removed for the vpns created in staging and production. That will cause the vpn-terraform job in the create-cloudfoundry pipeline to remove the vpns when it is run in those environments.
Pivotal tracker ticket 185156797 is related to this work and will remove the vpn code and configuration. That PR should not be merged until this change has successfully passed through production.
How to review
The changes will only impact the staging and production environment as there is no vpn config for dev.
Review code changes and run into a dev env.
The vpn-terraform job will fail in dev because it attempts to create an rds parameter group that has been manually added (I can see that the parameter group has been created in staging and prod because I viewed the vpn-state files in those environments). The pipeline should complete without any other failures.
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨