Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move business support javascript into tested module #211

Merged
merged 6 commits into from Jun 23, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 23, 2014

  • Introduce jasmine via official gem
    • Add jasmine:ci tests to default task
  • Move logic for "checking all checkboxes" into a re-usable module with jasmine test spec
  • Minor CSS cleanup for business support checkboxes
  • Remove flash notice animation which was unused
fofr added 6 commits Jun 20, 2014
* Configure to avoid default phantomjs download
* Run javascript tests by default
* There are no `flash-notice`s in the application
* Required for bootstrap and query libraries to be present
* Make a generic and re-usable “check all checkboxes” module, rather
than javascript specific to business support
* Make use of the admin template’s js module system
* Add first jasmine spec
* The checkboxes had a lot of custom CSS that was reproducing the
default bootstrap 3 styles, remove that CSS and use class helpers where
styling differs
* Add spacing between ‘All’ checkbox and the others (which was
previously intended but not working)
bishboria added a commit that referenced this pull request Jun 23, 2014
Move business support javascript into tested module
@bishboria bishboria merged commit 03ecc54 into master Jun 23, 2014
1 check passed
1 check passed
default "Build #127 succeeded on Jenkins"
Details
@bishboria bishboria deleted the jasmine-js-tests branch Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.