Move business support javascript into tested module #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fofr
commented
Jun 23, 2014
fofr
commented
- Introduce jasmine via official gem
- Add jasmine:ci tests to default task
- Move logic for "checking all checkboxes" into a re-usable module with jasmine test spec
- Minor CSS cleanup for business support checkboxes
- Remove flash notice animation which was unused
* Configure to avoid default phantomjs download
* Run javascript tests by default
* There are no `flash-notice`s in the application
* Required for bootstrap and query libraries to be present
* Make a generic and re-usable “check all checkboxes” module, rather than javascript specific to business support * Make use of the admin template’s js module system * Add first jasmine spec
* The checkboxes had a lot of custom CSS that was reproducing the default bootstrap 3 styles, remove that CSS and use class helpers where styling differs * Add spacing between ‘All’ checkbox and the others (which was previously intended but not working)
bishboria
added a commit
that referenced
this pull request
Jun 23, 2014
Move business support javascript into tested module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.