Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use select2 enhancement on assignee select on editions #280

Merged
merged 1 commit into from Nov 10, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 7, 2014

Apply the enhancement to every situation that a user needs to select a person from a long list.

screen shot 2014-11-07 at 14 26 09

@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Nov 10, 2014

LGTM, apart from a minor observation. there's a blank option right at the top of the select box on a new edition form:
screen shot 2014-11-10 at 9 47 43

@fofr
Copy link
Contributor Author

@fofr fofr commented Nov 10, 2014

Aren’t the options the same as what's currently live?

@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Nov 10, 2014

right, for some reason i was under the impression that editions have to be assigned to someone.

vinayvinay added a commit that referenced this pull request Nov 10, 2014
Use select2 enhancement on assignee select on editions
@vinayvinay vinayvinay merged commit ceb9a2d into master Nov 10, 2014
1 check passed
1 check passed
default "Build #383 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the select2-on-assignee branch Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.