Migration to add 'the' to will_continue_on text #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayvinay
force-pushed
the
fix-the-the
branch
from
ece0f5d
to
74d3b52
Compare
| def self.up | ||
| puts "Adding 'the' to the beginning of `will_continue_on` text on business support editions" | ||
| # BS editions which do not begin with 'The' or 'the' | ||
| bs_editions_to_fix = BusinessSupportEdition.where(will_continue_on: /\A(?!the\s).*/i) |
There was a problem hiding this comment.
Will this migration also add "the" to empty will_continue_on fields?
There was a problem hiding this comment.
@fofr: good spot. updated.
vinayvinay
force-pushed
the
fix-the-the
branch
from
74d3b52
to
6f9332f
Compare
www.agileplannerapp.com/boards/173808/cards/8718 Frontend will stop adding 'the' to will_continue_on text on business support editions: alphagov/frontend#695 This change allows editors to add 'the' when needed in the best way possible, and keeps it consistent with other formats. This migration fixes existing data to contain that word. Also, updated the hint text to suggest that editors need to add 'the' to will_continue_on in business support.
vinayvinay
force-pushed
the
fix-the-the
branch
from
6f9332f
to
6eaa800
Compare
|
👍 |
marksheldonGDS
added a commit
that referenced
this pull request
Nov 28, 2014
Migration to add 'the' to will_continue_on text
|
We need to let content designers know about this before we deploy. |
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
www.agileplannerapp.com/boards/173808/cards/8718
Frontend will stop adding 'the' to
will_continue_ontext on business support editions. This change allows editors to add 'the' when needed in the best way possible, and keeps it consistent with other formats.This migration fixes existing data to contain that word. Also, updated the hint text to suggest that editors need to add 'the' to
will_continue_onin business support.