Mark bad Content-Length tests as pending for Go 1.2 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression found when compiling and testing the router under go 1.2 compared to 1.1.2 (currently built against version). Since go 1.2 the behaviour for how bad Content-Length headers are handled has changed from providing a (private) error value that we could match against through to directly returning an `io.ErrUnexpectedEOF` error. Marking these tests as pending as they may eventually start working again and somebody should look at it again when that happens.
alext
added a commit
that referenced
this pull request
May 16, 2014
…ent-length-in-go-1.2 Mark bad Content-Length tests as pending for Go 1.2
govuk-ci
pushed a commit
that referenced
this pull request
Oct 9, 2017
Add deploy script for content-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression found when compiling and testing the router
under go 1.2 compared to 1.1.2 (currently built against version).
Since go 1.2 the behaviour for how bad Content-Length headers are
handled has changed from providing a (private) error value that we
could match against through to directly returning an
io.ErrUnexpectedEOFerror.Marking these tests as pending as they may eventually start working again
and somebody should look at it again when that happens.