Change the *_index.docs.count metric name #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics ending in `.count` are usually used for timers in StatsD, and there is some specific Graphite storage aggregation configuration for them [1]. Sum isn't the correct aggregation method for these counts, and the xFilesFactor needs to be lower to allow keeping the data for longer than 8 days, so just change the metric name so that it's treated like other gauges. 1: https://github.com/alphagov/govuk-puppet/blob/master/modules/govuk/files/node/s_graphite/storage-aggregation.conf#L35-L40 ``` [count] pattern = \.count$ aggregationMethod = sum xFilesFactor = 0.1 ```
cbaines
added a commit
to alphagov/govuk-puppet
that referenced
this pull request
Jun 10, 2019
Metrics ending in `.count` are usually used for timers in StatsD, and there is some specific Graphite storage aggregation configuration for them [1]. This change updates the use of the metrics to match the new name [2]. 1: https://github.com/alphagov/govuk-puppet/blob/master/modules/govuk/files/node/s_graphite/storage-aggregation.conf#L35-L40 ``` [count] pattern = \.count$ aggregationMethod = sum xFilesFactor = 0.1 ``` 2: alphagov/search-api#1577
cbaines
force-pushed
the
change-indices-statsd-metric-name
branch
from
f8adcb8
to
5716a23
Compare
barrucadu
approved these changes
Jun 12, 2019
cbaines
added a commit
to alphagov/govuk-puppet
that referenced
this pull request
Jun 24, 2019
Re-do the changes from [1] that were removed in [2]. 1: 6ba8846 2: 9811d5b Metrics ending in `.count` are usually used for timers in StatsD, and there is some specific Graphite storage aggregation configuration for them [3]. This change updates the use of the metrics to match the new name [4]. 3: https://github.com/alphagov/govuk-puppet/blob/master/modules/govuk/files/node/s_graphite/storage-aggregation.conf#L35-L40 ``` [count] pattern = \.count$ aggregationMethod = sum xFilesFactor = 0.1 ``` 4: alphagov/search-api#1577
cbaines
added a commit
to alphagov/govuk-puppet
that referenced
this pull request
Jul 1, 2019
Repeat the changes in 6ba8846. Metrics ending in `.count` are usually used for timers in StatsD, and there is some specific Graphite storage aggregation configuration for them [1]. This change updates the use of the metrics to match the new name [2]. 1: https://github.com/alphagov/govuk-puppet/blob/master/modules/govuk/files/node/s_graphite/storage-aggregation.conf#L35-L40 ``` [count] pattern = \.count$ aggregationMethod = sum xFilesFactor = 0.1 ``` 2: alphagov/search-api#1577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics ending in
.countare usually used for timers in StatsD, andthere is some specific Graphite storage aggregation configuration for
them [1].
Sum isn't the correct aggregation method for these counts, and the
xFilesFactor needs to be lower to allow keeping the data for longer
than 8 days, so just change the metric name so that it's treated like
other gauges.
1: https://github.com/alphagov/govuk-puppet/blob/master/modules/govuk/files/node/s_graphite/storage-aggregation.conf#L35-L40