Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve styles of 2-step code entry and locked account pages #394

Merged
merged 9 commits into from Sep 10, 2015
Merged

Improve styles of 2-step code entry and locked account pages #394

merged 9 commits into from Sep 10, 2015

Commits on Sep 9, 2015

  1. Use "2-step" name consistently in copy

    @fofr
    fofr committed Sep 9, 2015
    Copy the full SHA
    32caaab View commit details
    Browse the repository at this point in the history

  2. Create styled 2-step form 

    * Overrides default two_factor_authentication view
    @fofr
    fofr committed Sep 9, 2015
    Copy the full SHA
    7ad4ed7 View commit details
    Browse the repository at this point in the history

  3. Suppress navigation for 2-step nav form 

    * Hide the main navbar items, none of them work at this point
* Keep the sign out link so the user can return to the original sign in
form if they need to
    @fofr
    fofr committed Sep 9, 2015
    Copy the full SHA
    2c39f62 View commit details
    Browse the repository at this point in the history

  4. Allow more alert message types and track them 

    * Track the display of flash messages to Google Analytics, using the
same technique as Publisher
* Allow success, info, warning and danger styled flash messages as per
other admin apps
* Add display of flash[:error] so that two_factor_authentication gem
error messages display within pages
    @fofr
    fofr committed Sep 9, 2015
    Copy the full SHA
    0e93c0e View commit details
    Browse the repository at this point in the history

  5. Improve 2-step locked account view

    @fofr
    fofr committed Sep 9, 2015
    Copy the full SHA
    807d095 View commit details
    Browse the repository at this point in the history

  6. Better 2-step status copy 

    * Don’t distinguish between a successful sign in and successful 2-step
sign in
* Refer to the verification code being incorrect when attempts fail
    @fofr
    fofr committed Sep 9, 2015
    Copy the full SHA
    0db8f80 View commit details
    Browse the repository at this point in the history

  7. Increase max login attempt count 

    At the moment accounts don’t unlock after an hour and no email is sent.
To avoid this causing to many problems, increase the limit to 10 until
automatic unlocking is added: https://trello.com/c/LYxVsMEb/
    @fofr
    fofr committed Sep 9, 2015
    Copy the full SHA
    f9297b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2015

  1. Update account locked copy to resemble system 

    At the moment there are two locks:
* A sign in lock
* A 2-step lock

The 2-step lock doesn’t expire after an hour, and is separate to the
first lock. GOV.UK editors can’t unlock these accounts yet.
    @fofr
    fofr committed Sep 10, 2015
    Copy the full SHA
    36652d6 View commit details
    Browse the repository at this point in the history

  2. Move flash messages into partial and helper

    @fofr
    fofr committed Sep 10, 2015
    Copy the full SHA
    5484403 View commit details
    Browse the repository at this point in the history