Add a header to remove search bar #121
Conversation
|
It's probably worth adding a test where there are two elements with the id of (In some places Everything else LGTM (and this is really useful 👍 |
|
@dsingleton To clarify, the behaviour you would expect here is that the first search box encountered in the dom is removed but the second one (added by the application) remains? Should I be using a more tightly coupled selector to the top search box |
|
Yeah, probably. How about test mark markup like: <html>
<head>
</head>
<body>
<header id='global-header'>
<div id='search'></div>
</header>
<h1 id='search'>Search</h1>
</body>
</html>With the expected outcome that the search form in the header is removed and the subsequent |
|
Thanks @dsingleton this is really helpful. Going to work in these changes to improve the code and testing. Just noticed that this PR also doesn't remove quite enough. Going to make it remove that too. |
For manuals we need to remove the search box as we're going to be adding one that provides custom searching within the manual. This commit adds a new header that you can call from your app that will remove the search box from the top of the page. You can call it by adding the following code to your application's ApplicationController in a before filter: `set_slimmer_headers(remove_search: true)` Pivotal:https://www.pivotaltracker.com/n/projects/1261204/stories/88435634 This commit: - defines the `header` - adds the processor - adds a test for the processor.
alicebartlett
force-pushed
the
add-remove-search-header
branch
from
a851111
to
d18b165
Compare
|
@dsingleton OK, had another punt at this. I've tightened up the selector for the search box. Chatted with @edds and I'm just gonna scope the removal to a[href=#search] rather than add a wrapping div to the header which I can then remove. Both options are a bit icky, but this seems less likely to be removed by accident in the future. |
Add a header to remove search bar
For manuals we need to remove the search box in the page header as we're going to be adding one that provides custom searching within the manual.
This commit adds a new
headerthat you can call from your app that will remove the search box from the top of the page.You can call it by adding the following code to your applications ApplicationController in a before filter:
set_slimmer_headers(remove_search: true)Pivotal:https://www.pivotaltracker.com/n/projects/1261204/stories/88435634
This PR defines the header and adds the processor for the header and a test for the processor.
Further work
display:nonethe top search box on /search and the homepage (I'll open a PR...)