Copying meta tags with property #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, slimmer skipped meta tags with no name set, which dropped OpenGraph and Twitter meta tags. This now separately copies these over. Also adding tests for meta tag with property and test for duplicate property meta tags
dsingleton
added a commit
that referenced
this pull request
Jul 24, 2015
Copying meta tags with property
|
Cheers for the additional testing/rebase, appreciate its a bit of a pain. Thank you for the improvement 👍 |
|
Cheers! When might this appear on the published gem? We're building from my fork at present - ideally I'd like to revert to the mainstream development once the changes are integrated. |
|
@gilesdring I'll put together a release now. (A PR bumping the version/updating the changelog, which automatically publishes the gem when it's merged.) |
|
Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, slimmer skipped meta tags with no name set, which dropped
OpenGraph and Twitter meta tags. This now separately copies these
over.
Also adding tests for meta tag with property and test for duplicate property meta tags
NB was previously discussed in #132, but due to rebase / squash and exisiting commits to forked repo, had to abandon that PR and open this one...