Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all outcome templates to a single directory #1660

Closed
wants to merge 1 commit into from

Conversation

chrisroos
Copy link
Contributor

I find this slightly easier to browse than having the outcome templates mixed
alongside everything else in lib/smart_answer_flows.

I find this slightly easier to browse than having the outcome templates mixed
alongside everything else in lib/smart_answer_flows.
@chrisroos
Copy link
Contributor Author

@floehopper: You mentioned yesterday that you're less sure about this approach. Would you be able to explain why in here?

@floehopper
Copy link
Contributor

I find it more logical that the flow file and it's corresponding directory of outcome templates are in the same directory. I think what's actually confusing is having the data_partials, locales & shared_logic directories in the smart_answer_flows directory as well as the flow-related directories, but hopefully in time these will go away. I think it's a bit of a subjective decision, so I'm happy for you to move them if it makes more sense to you.

@tadast, @BenJanecke: Do you have any preference?

@tadast
Copy link
Contributor

tadast commented May 28, 2015

I agree with @floehopper that keeping all flow-related files bundled together makes sense. At the same time I like this approach, because it's closer to the conventional rails' app/ [views/controllers/models] dir structure.

I'd say a weak 👍 to this PR

@chrisroos
Copy link
Contributor Author

I agree with @floehopper that it's the mix of Smart Answer specific files/folders (i.e. flow files and outcome directories) and shared folders (i.e. data_partials, locales and shared_logic) that I find slightly confusing.

I'm less convinced about this change so I'm going to close this pull request.

@chrisroos chrisroos closed this Jun 1, 2015
@chrisroos chrisroos deleted the move-all-erb-templates-to-single-directory branch June 1, 2015 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants