Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check-uk-visa-v2 Smart Answer #1690

Closed
wants to merge 1 commit into from

Conversation

chrisroos
Copy link
Contributor

This v2 was last changed on April 22nd1, shortly before being merged to the
v1 on April 24th2.

@tadast had originally suggested keeping the v2 around as we were expecting
some more changes. We're yet to receive the changes and we should be using git
branching and Heroku from now on. @tadast confirmed that it was OK to remove
this v2 in a comment on 41276f.

Before removing I compared the v1 and v2 files:

  • Flow file differences

    $ diff lib/smart_answer_flows/check-uk-visa{,-v2}.rb
    < class CheckUkVisaFlow < Flow
    > class CheckUkVisaV2Flow < Flow
    < name 'check-uk-visa'
    > name 'check-uk-visa-v2'
    < status :published
    > status :draft
    < additional_countries = UkbaCountry.all
    > additional_countries = UkbaCountry.v2_all
    > outcome :outcome_visit_business_n
    > outcome :outcome_business_y
    
  • Locale file differences

    $ diff lib/smart_answer_flows/locales/en/check-uk-visa{,-v2}.yml
    < check-uk-visa:
    > check-uk-visa-v2:
    
  • UKBA additional countries data differences

    $ diff lib/data/ukba_additional_countries{,_v2}.yml
    # No difference
    

This v2 was last changed on April 22nd[1], shortly before being merged to the
v1 on April 24th[2].

@tadast had originally suggested keeping the v2 around as we were expecting
some more changes. We're yet to receive the changes and we should be using git
branching and Heroku from now on. @tadast confirmed that it was OK to remove
this v2 in a comment on 41276f.

Before removing I compared the v1 and v2 files:

* Flow file differences

        $ diff lib/smart_answer_flows/check-uk-visa{,-v2}.rb
        < class CheckUkVisaFlow < Flow
        > class CheckUkVisaV2Flow < Flow
        < name 'check-uk-visa'
        > name 'check-uk-visa-v2'
        < status :published
        > status :draft
        < additional_countries = UkbaCountry.all
        > additional_countries = UkbaCountry.v2_all
        > outcome :outcome_visit_business_n
        > outcome :outcome_business_y

* Locale file differences

        $ diff lib/smart_answer_flows/locales/en/check-uk-visa{,-v2}.yml
        < check-uk-visa:
        > check-uk-visa-v2:

* UKBA additional countries data differences

        $ diff lib/data/ukba_additional_countries{,_v2}.yml
        # No difference

[1]: 0a40eeb
[2]: 41276f5
@chrisroos chrisroos closed this Jun 9, 2015
@chrisroos chrisroos deleted the remove-check-uk-visa-v2 branch June 9, 2015 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant