Fix contact blocks in uk-benefits-abroad #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the Govspeak docs [1] suggest that a contact block with generate HTML line-break elements between each line, this doesn't appear to be the case (I have raised a GitHub issue [2] asking about this). It appears as if historically we've been working around this issue by adding two trailing spaces to the lines within the contact blocks. This relies on a feature of Kramdown which converts the two trailing spaces into HTML line break elements [3]. Unfortunately the trailing spaces for the contact blocks in uk-benefits-abroad were, almost certainly accidentally, lost in this commit [4]. Many developers have their editors set to automatically remove trailing whitespace to make git history as clear as possible. I think this is generally a good thing, but I suspect it may have been what led to these significant trailing spaces being lost. As a temporary solution, I've added two trailing backslashes to the relevant lines. This is a Kramdown alternative to the two trailing spaces with the advantage that hopefully they shouldn't get removed so easily by accident. I think the correct longer-term solution is probably to fix Govspeak so that it's behaviour matches the documentation, but since many projects use Govspeak, it may take a while to get the change accepted. [1]: https://github.com/alphagov/govspeak#contact [2]: alphagov/govspeak#55 [3]: http://kramdown.gettalong.org/syntax.html#paragraphs [4]: 1a96852
Based on an email from @lutgendorff, these two contact blocks should be the same: * Both should say "Outside the UK:" instead of "Outside the UK call" * Both should include the link to call-charges In the longer term it would be good to DRY up the two contact blocks, but since I'm about to convert the outcomes in this flow to use ERB templates, I'm going to hold off on that for now.
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address problems with the contact blocks in the
uk-benefits-abroad flow:
See individual commit notes for further details.