PR 2027 illustration #2028
Closed
PR 2027 illustration #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for making an Afghanistan specific change to this Smart Answer.
1. Added "afghanistan" as a response to "which_country_are_you_in?" in overseas-passports-questions-and-responses.yml.
2. Regenerated overseas-passports-responses-and-expected-results.yml with:
$ rails r script/generate-responses-and-expected-results-for-smart-answer.rb\
overseas-passports
3. Regenerated overseas-passports-files.yml with:
$ rails r script/generate-checksums-for-smart-answer.rb overseas-passports
4. Updated overseas-passports test artefacts with:
$ RUN_REGRESSION_TESTS=overseas-passports \
ruby test/regression/smart_answers_regression_test.rb
… in Afghanistan. For further details see: https://www.pivotaltracker.com/n/projects/1270592/stories/105008654 1. Updated overseas-passports-files.yaml: $ rails r script/generate-checksums-for-smart-answer.rb overseas-passports 2. Updated regression test artefacts for overseas-passports: $ RUN_REGRESSION_TESTS=overseas-passports \ ruby test/regression/smart_answers_regression_test.rb
These have served their purpose in allowing us to see the effect of the change made in the previous commit. This is essentially a manual revert of the steps in the commit titled "Add Afghanistan to overseas-passports regression tests".
|
I'm closing this as we don't need it open for it to serve its purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely for the purposes of illustration and shouldn't be merged.
I didn't do a very good job of explaining how we could use the regression tests to test the effect of a change and thought this worked example might help.