Improve unit tests for QuestionPresenter#error #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
My main objective here was to cover the behaviour when an `SmartAnswer::InvalidResponse` is raised with a text message and the default error message in the i18n YAML file interpolates this error. Currently this behaviour is only tested in the `InputValidationTest` integration test, but there's so much going on in there it's hard to see the wood for the trees. I'm not convinced that this behaviour is very sensible nor do I think it is used anywhere in the published smart answer flows. However, it does appear as if there are quite a few places where a custom String is set as the exception message rather than an error message key. Since I believe the mechanism described above is the only way such messages could currently be displayed to the user, I'm loathe to remove it without providing a replacement. I've also clarified that the final fallback error message is system-wide and not just for the question's flow.
floehopper
force-pushed
the
improve-unit-tests-for-question-presenter-error
branch
from
a5ebe2b
to
6a60bf3
Compare
|
I've rebased this against master and force-pushed in preparation for merging. |
|
I believe the build failed due to a race condition in one of the JS-enabled integration tests. I've kicked off another build manually. |
floehopper
added a commit
that referenced
this pull request
Nov 16, 2015
…n-presenter-error Improve unit tests for QuestionPresenter#error
floehopper
deleted the
improve-unit-tests-for-question-presenter-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main objective here was to cover the behaviour when an
SmartAnswer::InvalidResponseis raised with a text message and the defaulterror message in the i18n YAML file interpolates this error. Currently this
behaviour is only tested in the
InputValidationTestintegration test, butthere's so much going on in there it's hard to see the wood for the trees.
I'm not convinced that this behaviour is very sensible nor do I think it is used
anywhere in the published smart answer flows. However, it does appear as if
there are quite a few places where a custom
Stringis set as the exceptionmessage rather than an error message key. Since I believe the mechanism
described above is the only way such messages could currently be displayed to
the user, I'm loathe to remove it without providing a replacement.
I've also clarified that the final fallback error message is system-wide and not
just for the question's flow.
Expected observable changes