Add logging config for when deployed to Heroku #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erkde
force-pushed
the
add_stdout_logging_for_heroku_deployments
branch
from
7e6560a
to
de99822
Compare
|
Just rebased with master, and force pushed back |
| @@ -71,5 +71,12 @@ | |||
| config.logstasher.enabled = true | |||
| config.logstasher.logger = Logger.new("#{Rails.root}/log/#{Rails.env}.json.log") | |||
| config.logstasher.suppress_app_logs = true | |||
| else | |||
There was a problem hiding this comment.
Unless-else seems to be considered as a something that reads badly. It would be better to invert the conditional and have it as if - else.
There was a problem hiding this comment.
Ok, just inverted it for readability
|
I think this is ok. |
Heroku needs application logging to point to STDOUT to appear in the logs: https://devcenter.heroku.com/articles/rails4
Invert unless something.present? else for if something.blank? else.
erkde
force-pushed
the
add_stdout_logging_for_heroku_deployments
branch
from
e846a0a
to
7bc1615
Compare
erkde
pushed a commit
that referenced
this pull request
Jan 22, 2016
…deployments Add logging config for when deployed to Heroku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we use Heroku for our all out staging servers for fact checking processes, we need to point Rails logging to STDOUT for the application log to be available when on Heroku:
https://devcenter.heroku.com/articles/rails4
@dsingleton @jennyd