Remove unused state attribute from flow
#2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's weird - nice to remove then, lgtm |
|
Rebasing against master and force-pushing in preparation for merging. |
As far as I can tell this is not used and I'm pretty sure it's *never* been used. The state for a request seems to be handled entirely locally within the `Flow#process` method.
Instance variables are assigned `nil` by default, so this assignment is unnecessary.
floehopper
force-pushed
the
remove-unused-state-attribute-from-flow
branch
from
1e60f3f
to
3ee1097
Compare
floehopper
added a commit
that referenced
this pull request
Mar 21, 2016
…from-flow Remove unused `state` attribute from flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As far as I can tell this is not used and I'm pretty sure it's never been used. The state for a request seems to be handled entirely locally within the
Flow#processmethod.External changes
None.