Fix no method error undefined method transition on outcome #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0929036. It was a mistake to remove the `Outcome#transition` method which raised a `SmartAnswer::InvalidNode` exception. I hadn't noticed that this exception is rescued and the app responds with a "404 Not Found" [1]. The latter seems like sensible behaviour and so I'm restoring the previous implementation in this commit. This should prevent exceptions like this one [2] from appearing in Errbit. [1]: https://github.com/alphagov/smart-answers/blob/bf77a584737d8dbfee5694b64d5ad8870ebe0445/app/controllers/smart_answers_controller.rb#L7 [2]: https://errbit.publishing.service.gov.uk/apps/533c35ae0da1159384044f5f/problems/572087f96578631e0c660b00
|
Good catch @floehopper; LGTM |
pmanrubia
deleted the
fix-no-method-error-undefined-method-transition-on-outcome
branch
|
@pmanrubia: Thanks. Sorry for making the mistake in the first place! |
|
For some reason it doesn't look as if a CI build ran against this build. And it looks as if the CI build of master has just failed. I'm running the build locally to see whether I can see what's going on. |
|
Oh - it's a Rubocop violation. I'll submit a PR to fix it. |
floehopper
added a commit
that referenced
this pull request
Apr 29, 2016
This was accidentally introduced in #2494.
|
Thank you for the follow-up @floehopper, and for adding the missing tests covering |
|
See #2495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 0929036.
It was a mistake to remove the
Outcome#transitionmethod which raised aSmartAnswer::InvalidNodeexception. I hadn't noticed that this exception is rescued and the app responds with a 404 Not Found. The latter seems like sensible behaviour and so I'm restoring the previous implementation in this PR. This should prevent exceptions like this one from appearing in Errbit.This PR also adds test coverage to hopefully avoid the same mistake happening again.
External changes
Adding extra responses to the path of an outcome page should result in a
404 No Founderror instead of a5XXerror and no exception should be recorded in Errbit.Before
https://www.gov.uk/overseas-passports/y/australia/renewing_new/adult/born-in-uk-pre-1983 -> "Sorry, we are experiencing technical difficulties"`
After
https://www.gov.uk/overseas-passports/y/australia/renewing_new/adult/born-in-uk-pre-1983 -> "Page not found"