Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Services.worldwide_api method #2498

Merged
merged 1 commit into from May 6, 2016

Commits on May 6, 2016

  1. Simplify Services.worldwide_api method

    There is already a mechanism available for overriding the URI for specific
    services, so there is no need to have some special code to do this. Service
    URI's are automatically looked up via `Plek` and they can be overridden using
    environment variables of the form: `PLEK_SERVICE_<service-name>_URI` (see [1]).
    
    In this case, we can set the `PLEK_SERVICE_WHITEHALL_ADMIN_URI` environment
    variable to "https://www.gov.uk" if we want to use the production website to
    supply the data for the Worldwide API.
    
    I've updated both the `developing-without-vm` and `developing-using-vm`
    documentation to explain how to cope with this change.
    
    I have also updated the `common-errors` documentation to reflect the error that
    occurs if the Worldwide API is not pointing at an appropriate URI.
    
    [1]: https://github.com/alphagov/plek/blob/b1f917cd6498aea8867728dab0132d0373ca702b/README.md#for-base-urls
    floehopper committed May 6, 2016
    Configuration menu
    Copy the full SHA
    9c01ec5 View commit details
    Browse the repository at this point in the history