Refactor commodity code flow #5545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the commodity code flow to use dynamic options. This simplifies the flow as previously it handled dynamic questions by have multiple question nodes with the same question, but different options.
This switches the commodity code flow to use query parameters as the response store instead of the URL path. This change is a part of a migration for all flows that previously used URL path to use query parameters.
theseanything
force-pushed
the
refactor-commodity-code
branch
from
b0b303b
to
ba9e2f6
Compare
32 tasks
|
Closing for now - as not a team priority for now. Should be revisit one day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the commodity code flow to use dynamic options and store responses using query parameters
Using dynamic options simplifies the flow as previously it had multiple question nodes with the same question, but different options. This created redundant and duplicative content to maintain and also made the flow definition more difficult to read. This was a precursor step required to enable the flow to use query parameters, as the node names would be visible in the url and this makes them more user friendly.
This switches the commodity code flow to use query parameters as the response store instead of the URL path. This change is a part of a migration for all flows that previously used URL path to use query parameters.