Use query parameters for vat payment deadlines flow #5555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
This moves the initialisation logic from the on_response block to the setup method. This also moves logic from the next node block that should be in the on_response block.
theseanything
force-pushed
the
refactor-vat-payment-deadlines
branch
from
c11f24f
to
c9610f9
Compare
This makes the node names for the vat payment deadlines flow more concise and human readable. This is part of the work to enable the flow to use query parameters where the node names will be visible in the URL.
This switches the flow to use query parameters as the response store instead of the URL path. This change is a part of a migration for all flows that previously used URL path to use query parameters. This also renames the nodes to be more human readable, as they will now show in the url.
theseanything
force-pushed
the
refactor-vat-payment-deadlines
branch
from
c9610f9
to
e15353d
Compare
|
Closing for now - as not a team priority for now. Should be revisit one day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the flow to use query parameters as the response store instead of the URL path. This change is a part of a migration for all flows that previously used URL path to use query parameters. This also renames the nodes to be more human readable, as they will now show in the url.