New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Dart Sass from LibSass #6634
Conversation
fe1b77f
to
a3a01f8
Compare
a3a01f8
to
81f03f2
Compare
81f03f2
to
4bab80d
Compare
4bab80d
to
1d357d6
Compare
1d357d6
to
66e4489
Compare
66e4489
to
eb54e2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Matt, great work. All looks good and works fine. I've just added a couple of small comments and a general note around vendor CSS
I'm adding a note regarding vendor CSS which is currently uncompressed. It seems that
However, this process seems closely linked to the sassc-rails gem, which has been removed. The only alternative I've come across for CSS compression is to add At present, the vendor CSS folder doesn't seem to be used in other UX applications that are being migrated to Dart Sass. Otherwise, Sass files are compressed before being handled by the asset pipeline. |
eb54e2d
to
e2e6e23
Compare
e2e6e23
to
3d5dcd7
Compare
@jon-kirwan I've made the requested changes, please could you have a final check? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All working fine for me and the changes look great! Thanks Matt 👍
3d5dcd7
to
437440b
Compare
- Create `dartsass.builds` initializer and add all Sass files to be compiled. See https://github.com/rails/dartsass-rails#configuring-builds - Create .keep - Update manifest file to use /builds directory - Ignore /builds
437440b
to
ad0a96a
Compare
What
Migrate Smart Answers to Dart Sass from LibSass Trello
Why
Visual Changes
None.
Anything else
Once the PR gets the green light, any temporary commits and references to local gems e.g.
gem "govuk_publishing_components", path: "../govuk_publishing_components"
will be removed.See: