Eta September 2024 nvn/eea warning callout #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding callout text.
Moving ETA callout after review of draft content.
Moving September 2024 ETA partial after review.
Adding snippet of new callout to @eta_test
syed-ali-tw
reviewed
May 23, 2024
| @@ -3,6 +3,7 @@ | |||
| <% end %> | |||
|
|
|||
| <% govspeak_for :body do %> | |||
|
|
|||
There was a problem hiding this comment.
do we need this extra line?
There was a problem hiding this comment.
Have removed this one.
syed-ali-tw
reviewed
May 23, 2024
|
The first commit message has a "WIP" can we reword the message? |
syed-ali-tw
reviewed
May 23, 2024
| @@ -18,7 +18,8 @@ class CheckUkVisaFlowTest < ActiveSupport::TestCase | |||
| @b1_b2_country = "syria" | |||
| @youth_mobility_scheme_country = "canada" | |||
|
|
|||
| @eta_text = "If you’re travelling on or after 22 February 2024, you’ll need to apply for an electronic travel authorisation (ETA)" | |||
There was a problem hiding this comment.
was this a redundant text that we just removed?
There was a problem hiding this comment.
No—it was split into two separate pieces of text (one for non-visa nationals, and one for EEA country nationals). See the next two added lines.
Depending on whether the passport holder's country is an EEA country or a non-visa national country, show a different date in the callout box text. Add tests to ensure that when the passport holder's country is neither an EEA country nor a non-visa national country, that no ETA callout text is shown.
No confirmed date for either user group yet. But we know users are looking for assurance, so adding a holding message. Keeping the 2 separate callouts so we can add dates to separate groups when they are ready.
Update the tests for the check UK visa flow to reflect the changes made to the outcome text related to non-visa national and EEA countries and their need for electronic travel authorisation.
mtaylorgds
force-pushed
the
ETA-nvn/EEA-warning-callout-new-pr-for-new-preview-deploy
branch
from
0ff6e80
to
62e578f
Compare
I guess this was a WIP commit, but to get rid of it now would involve messing with the entire branch history, which I don't really want to do at this point. |
syed-ali-tw
approved these changes
May 24, 2024
mtaylorgds
deleted the
ETA-nvn/EEA-warning-callout-new-pr-for-new-preview-deploy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content storytime: https://trello.com/c/SwjCds1e/263-3-april-eta-callout-for-2-user-groups-on-check-if-you-need-a-uk-visa
Adding in a callout for non-visa national and EEA user groups that they may need an ETA if coming to the UK after September 2024.
Supersedes #6729, since the preview environment for that PR has expired.
Follow these steps if you are doing a Rails upgrade.