Update check for mainstream publisher sign in #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This PR breaks the existing test: alphagov/publisher#210
|
Is it possible to write this test in a way that will work with both the existing and new layouts? We could probably remove that line entirely, as I don't think it adds value in this case. |
|
I didn't want to second guess why the test was added. |
|
Tested against both preview and current production, and is good. |
alext
added a commit
that referenced
this pull request
Jun 24, 2014
Update check for mainstream publisher sign in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using govuk_admin_template publisher#210