Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check for mainstream publisher sign in #96

Merged
merged 1 commit into from Jun 24, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 24, 2014

* This PR breaks the existing test:
alphagov/publisher#210
@alext
Copy link
Contributor

@alext alext commented Jun 24, 2014

Is it possible to write this test in a way that will work with both the existing and new layouts? We could probably remove that line entirely, as I don't think it adds value in this case.

@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 24, 2014

I didn't want to second guess why the test was added.
The text "Sign out" is present on production, but within a hidden dropdown — I'm not sure how the test deals with this.

@alext
Copy link
Contributor

@alext alext commented Jun 24, 2014

Tested against both preview and current production, and is good.

alext added a commit that referenced this pull request Jun 24, 2014
Update check for mainstream publisher sign in
@alext alext merged commit 146b614 into master Jun 24, 2014
@alext alext deleted the publisher-signed-in-text branch Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.