Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upload exported CSV file to S3 rather than attaching it" #413

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@benjamineskola
Copy link
Contributor

benjamineskola commented Feb 5, 2020

Reverts #411 which introduces a bug; corrected PR forthcoming.

@issyl0
issyl0 approved these changes Feb 5, 2020
Copy link
Member

issyl0 left a comment

I'd prefer a fix forward, as this has only deployed to integration, but we probably need longer than the rest of the day to figure out why the CSV export is only sending the filename rather than a link to the whole file.

@benjamineskola benjamineskola merged commit 4d333ec into master Feb 5, 2020
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/security No security issues found
Details
@benjamineskola benjamineskola deleted the revert-411-switch-global-export-to-s3 branch Feb 5, 2020
@thomasleese

This comment has been minimized.

Copy link
Contributor

thomasleese commented Feb 6, 2020

I agree it might have been easier to fix forward here, Support API doesn't get released very often, and it's possible to add messages in the Release app telling other people not to deploy it, but oh well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.