Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Upload exported CSV file to S3 rather than attaching it" #413

Merged
merged 1 commit into from Feb 5, 2020
Merged

Revert "Upload exported CSV file to S3 rather than attaching it" #413

merged 1 commit into from Feb 5, 2020

Conversation

benjamineskola
Copy link
Contributor

@benjamineskola benjamineskola commented Feb 5, 2020 •
edited

Reverts #411 which introduces a bug; corrected PR forthcoming.

issyl0
issyl0 approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a fix forward, as this has only deployed to integration, but we probably need longer than the rest of the day to figure out why the CSV export is only sending the filename rather than a link to the whole file.

@benjamineskola benjamineskola merged commit 4d333ec into master Feb 5, 2020
@benjamineskola benjamineskola deleted the revert-411-switch-global-export-to-s3 branch February 5, 2020 16:16
@thomasleese
Copy link
Contributor

I agree it might have been easier to fix forward here, Support API doesn't get released very often, and it's possible to add messages in the Release app telling other people not to deploy it, but oh well!

@benjamineskola benjamineskola mentioned this pull request Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjamineskola @thomasleese @issyl0