Improving error handling #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Zendesk's API validations and error cases are no documented, it is possible that the support app's validations let invalid requests slip through. This means that it's not possible to raise a ticket from the user's request. Prior to this change, such cases would generate a standard Rails 500 error. After this change, the user sees a much clearer error message and receives a text representation of the ticket that was going to be raised, in case they would like to review it or forward it on via email.
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Zendesk's API validations and error cases are not documented,
it is possible that the support app's validations let invalid requests
slip through. This means that it's not possible to raise a ticket
from the user's request.
Prior to this change, such cases would generate a standard Rails 500 error.
After this change, the user sees a much clearer error message and
receives a text representation of the ticket that was going to be
raised, in case they would like to review it or not have to type it out again.