Some search and keyboard navigation updates #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
force-pushed
the
toc-updates-for-a11y
branch
4 times, most recently
from
1307ec6
to
40f69b0
Compare
andysellick
reviewed
Mar 8, 2021
danacotoran
force-pushed
the
toc-updates-for-a11y
branch
from
85d44e0
to
88430c0
Compare
andysellick
approved these changes
Mar 10, 2021
Add a button to the search form as suggested in the DAC Acessibility audit. Make input label more descriptive to help screen reader users determine the purpose of the form. Prevent tabbing beyond the TOC modal and/or search results when they are open. Screen reader users should also not be able to access page content that is not visible on the screen.
Update results title to display "0 Results" if no results are returned on submitting the form. Currently if the form is submitted without typing anything in, the search results title says "Loading search index".
danacotoran
force-pushed
the
toc-updates-for-a11y
branch
from
88430c0
to
ce90c9c
Compare
3 tasks
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a button to the search form as suggested in the DAC Accessibility audit. Make input label more descriptive to help screen reader users determine the purpose of the form.
Search field before
Search field after
Prevent tabbing beyond the TOC modal and/or search results when they are open. Screen reader users should also not be able to access page content that is not visible on the screen.
This should help address issues 5 and 10 on this form.
Trello card: https://trello.com/c/vv0OR35g/630-march-update-tech-docs-template