Skip to content
This repository has been archived by the owner on Nov 22, 2017. It is now read-only.

Fix measure with complex measure conditions rendering. #53

Merged
merged 1 commit into from
Jan 29, 2013

Conversation

saulius
Copy link
Contributor

@saulius saulius commented Jan 29, 2013

To be honest, I think it's error in the data as measure conditions are:

=> [#<MeasureCondition @values={:measure_condition_sid=>549716, :measure_sid=>2891442, :condition_code=>"L", :component_sequence_number=>1, :condition_duty_amount=>58.23, :condition_monetary_unit_code=>"EUR", :condition_measurement_unit_code=>"DTN", :condition_measurement_unit_qualifier_code=>nil, :action_code=>"01", :certificate_type_code=>nil, :certificate_code=>nil, :created_at=>nil, :updated_at=>nil}>,
 #<MeasureCondition @values={:measure_condition_sid=>549717, :measure_sid=>2891442, :condition_code=>"L", :component_sequence_number=>2, :condition_duty_amount=>38.82, :condition_monetary_unit_code=>"EUR", :condition_measurement_unit_code=>"DTN", :condition_measurement_unit_qualifier_code=>nil, :action_code=>"01", :certificate_type_code=>nil, :certificate_code=>nil, :created_at=>nil, :updated_at=>nil}>,
 #<MeasureCondition @values={:measure_condition_sid=>549718, :measure_sid=>2891442, :condition_code=>"L", :component_sequence_number=>3, :condition_duty_amount=>35.19, :condition_monetary_unit_code=>"EUR", :condition_measurement_unit_code=>"DTN", :condition_measurement_unit_qualifier_code=>nil, :action_code=>"01", :certificate_type_code=>nil, :certificate_code=>nil, :created_at=>nil, :updated_at=>nil}>,
 #<MeasureCondition @values={:measure_condition_sid=>549719, :measure_sid=>2891442, :condition_code=>"L", :component_sequence_number=>5, :condition_duty_amount=>0.0, :condition_monetary_unit_code=>"EUR", :condition_measurement_unit_code=>"DTN", :condition_measurement_unit_qualifier_code=>nil, :action_code=>"07", :certificate_type_code=>nil, :certificate_code=>nil, :created_at=>nil, :updated_at=>nil}>]

So sequence numbers are 1,2,3,5(?). Previous code version assumed that they will be in correct sequence. Reworked to use sorting and pick the one before actual measure condition.

This is for https://www.pivotaltracker.com/story/show/43298641.

jabley added a commit that referenced this pull request Jan 29, 2013
Fix measure with complex measure conditions rendering.
@jabley jabley merged commit f7d3625 into master Jan 29, 2013
@jabley
Copy link
Contributor

jabley commented Jan 29, 2013

I'll add something to trade-tariff-suite to capture this as well. Currently that's a bit of an organic evolution and we might want to think about structuring it a bit better, but for now I'm just happy adding stuff to it.

@jabley jabley deleted the fix_measure_condition_rendering branch January 29, 2013 23:33
matthewford added a commit that referenced this pull request Oct 24, 2016
Call the `FS.clearUserCookie` function from the FullStory plugin at t…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants