Skip to content
This repository has been archived by the owner on Oct 9, 2018. It is now read-only.

Remove Google Analytics classic #88

Merged
merged 2 commits into from Jun 1, 2015
Merged

Remove Google Analytics classic #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a02408b
Remove classic analytics
fofr May 14, 2015
a0a1543
Update frontend_toolkit to 4.0.0
fofr May 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion _assets_pipeline/govuk_toolkit
Open in desktop
Submodule govuk_toolkit updated 19 files
+1 −1 .gitignore
+40 −0 CHANGELOG.md
+1 −2 Gruntfile.js
+1 −1 VERSION.txt
+26 −29 docs/analytics.md
+58 −5 docs/javascript.md
+64 −0 javascripts/govuk/analytics/analytics.js
+0 −127 javascripts/govuk/analytics/google-analytics-classic-tracker.js
+23 −0 javascripts/govuk/analytics/google-analytics-universal-tracker.js
+0 −50 javascripts/govuk/analytics/tracker.js
+28 −11 javascripts/govuk/multivariate-test.js
+7 −2 spec/manifest.js
+4 −4 spec/support/LocalTestRunner.html
+3 −11 spec/support/load.js
+38 −31 spec/unit/MultivariateTestSpec.js
+63 −0 spec/unit/analytics/AnalyticsSpec.js
+0 −124 spec/unit/analytics/GoogleAnalyticsClassicTrackerSpec.js
+0 −74 spec/unit/analytics/TrackerSpec.js
+4 −1 stylesheets/_colours.scss
9 changes: 4 additions & 5 deletions _assets_pipeline/javascripts/analytics-init.js
View file
Open in desktop
@@ -1,17 +1,16 @@
(function() {
"use strict";

GOVUK.Tracker.load();
GOVUK.Analytics.load();
var cookieDomain = (document.domain === 'www.gov.uk') ? '.www.gov.uk' : document.domain;

GOVUK.analytics = new GOVUK.Tracker({
universalId: 'UA-26179049-7',
classicId: 'UA-26179049-1',
GOVUK.analytics = new GOVUK.Analytics({
universalId: 'UA-26179049-1',
cookieDomain: cookieDomain
});

if (window.devicePixelRatio) {
GOVUK.analytics.setDimension(11, window.devicePixelRatio, 'Pixel Ratio', 2);
GOVUK.analytics.setDimension(11, window.devicePixelRatio);
}

GOVUK.analytics.trackPageview();
Expand Down
3 changes: 1 addition & 2 deletions _assets_pipeline/javascripts/app.js
View file
Open in desktop
Expand Up @@ -2,9 +2,8 @@
//= require ./vendor/jquery/jquery-migrate-1.2.1.js
//= require ./vendor/jquery/jquery-ui-1.10.4.js
//= require ../govuk_toolkit/javascripts/vendor/jquery/jquery.player.min.js
//= require ../govuk_toolkit/javascripts/govuk/analytics/google-analytics-classic-tracker.js
//= require ../govuk_toolkit/javascripts/govuk/analytics/google-analytics-universal-tracker.js
//= require ../govuk_toolkit/javascripts/govuk/analytics/tracker.js
//= require ../govuk_toolkit/javascripts/govuk/analytics/analytics.js
//= require analytics-init.js

// Avoid `console` errors in browsers that lack a console.
Expand Down