Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvements for bulk adding #159

Merged
merged 6 commits into from Jan 24, 2014
Merged

Usability improvements for bulk adding #159

merged 6 commits into from Jan 24, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 23, 2014

  • Highlight existing paths on the confirmation page
  • Update header to match mapping index view
  • Remove some spacing between fields in the form for consistency
  • Add messaging to clarify that mappings won't be saved immediately and to explain a bit about what happens
    • Make the button text say 'continue' for the same reasons
  • Split the redirect-to URL onto a new line for better readability
  • Make it clear that full URLs can be entered into the old URLs field

Many of these improvements came about after pairing with @rjc123.

Paul Hayes added 6 commits Jan 23, 2014
* Include a border and wrap the h1
* The form-group class was adding superfluous margins
* Rename submit mappings to continue
* Add a message which explains what will happen for the tentative user
* Long target URLs are easier to read when broken away from the main
title and made a little smaller
* @rjc123 suggested highlighting existing paths with the same colour
being used for the warning message at the top. I think this makes sense.
<%= button_tag 'Continue', class: 'add-vertical-margins btn btn-success' %>

<div class="row">
<p class="col-md-8 text-muted">When you submit the form we’ll convert the URLs to lowercase and order the query parameters so they are consistent, and we’ll check whether they already exist. There will be a review step before your changes are saved.</p>

This comment has been minimized.

@jamiecobbett

jamiecobbett Jan 24, 2014
Contributor

I like this 👍

jamiecobbett added a commit that referenced this pull request Jan 24, 2014
Usability improvements for bulk adding
@jamiecobbett jamiecobbett merged commit 93f7e28 into master Jan 24, 2014
@jamiecobbett jamiecobbett deleted the bulk-add-full-url branch Jan 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.