Usability improvements for bulk adding #159
Merged
Conversation
6 commits
Jan 23, 2014
added * Include a border and wrap the h1
* The form-group class was adding superfluous margins
* Rename submit mappings to continue * Add a message which explains what will happen for the tentative user
* Long target URLs are easier to read when broken away from the main title and made a little smaller
* @rjc123 suggested highlighting existing paths with the same colour being used for the warning message at the top. I think this makes sense.
<%= button_tag 'Continue', class: 'add-vertical-margins btn btn-success' %> | ||
|
||
<div class="row"> | ||
<p class="col-md-8 text-muted">When you submit the form we’ll convert the URLs to lowercase and order the query parameters so they are consistent, and we’ll check whether they already exist. There will be a review step before your changes are saved.</p> |
jamiecobbett
Jan 24, 2014
Contributor
I like this 👍
I like this
jamiecobbett
added a commit
that referenced
this pull request
Jan 24, 2014
Usability improvements for bulk adding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Many of these improvements came about after pairing with @rjc123.