Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability improvements for bulk adding #159

Merged
merged 6 commits into from Jan 24, 2014
Merged

Usability improvements for bulk adding #159

merged 6 commits into from Jan 24, 2014

Conversation

fofr
Copy link
Contributor

@fofr fofr commented Jan 23, 2014

  • Highlight existing paths on the confirmation page
  • Update header to match mapping index view
  • Remove some spacing between fields in the form for consistency
  • Add messaging to clarify that mappings won't be saved immediately and to explain a bit about what happens
    • Make the button text say 'continue' for the same reasons
  • Split the redirect-to URL onto a new line for better readability
  • Make it clear that full URLs can be entered into the old URLs field

Many of these improvements came about after pairing with @rjc123.

Paul Hayes added 6 commits January 23, 2014 17:12
Make it clear that full URLs can be entered
4a7e443
Match the header pattern used elsewhere
64c697c 
* Include a border and wrap the h1
Remove extra spacing between type and Old URLs
0734e94 
* The form-group class was adding superfluous margins
Clarify that mappings aren't saved yet
8a190b1 
* Rename submit mappings to continue
* Add a message which explains what will happen for the tentative user
Break redirect to URL on to new line
a5aabb5 
* Long target URLs are easier to read when broken away from the main
title and made a little smaller
On confirmation highlight existing paths
b7abe64 
* @rjc123 suggested highlighting existing paths with the same colour
being used for the warning message at the top. I think this makes sense.
jamiecobbett
jamiecobbett reviewed Jan 24, 2014
View reviewed changes
app/views/mappings/new_multiple.html.erb
<%= button_tag 'Continue', class: 'add-vertical-margins btn btn-success' %>

<div class="row">
<p class="col-md-8 text-muted">When you submit the form we’ll convert the URLs to lowercase and order the query parameters so they are consistent, and we’ll check whether they already exist. There will be a review step before your changes are saved.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 👍

jamiecobbett added a commit that referenced this pull request Jan 24, 2014
@jamiecobbett
Merge pull request #159 from alphagov/bulk-add-full-url
93f7e28 
Usability improvements for bulk adding
@jamiecobbett jamiecobbett merged commit 93f7e28 into master Jan 24, 2014
@jamiecobbett jamiecobbett deleted the bulk-add-full-url branch January 24, 2014 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fofr @jamiecobbett