Create a go to mapping modal #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fofr
commented
Apr 11, 2014
fofr
commented
- When pressing “g m” a modal appears asking for an old URL, entering the URL will take you directly to that mappings edit screen
- “g m” for “go to mapping”
- Uses the existing find_global method to resolve a mapping without site
added 3 commits
April 11, 2014 13:35
* When pressing “g m” a modal appears asking for an old URL, entering the URL will take you directly to that mappings edit screen * “g m” for “go to mapping” * Uses the existing find_global method to resolve a mapping without site
* There were two “Old URL” fields and the assertion was looking at the wrong one * Instead look for “Old URLs”
|
This is neat, but I have a concern here about the lack of discoverability. I had expected us to add a link to open this dialog - is that something you plan to add soon? |
|
You're right that discoverability is a concern, creating a UI or link to the modal is a much bigger problem that I didn't want to solve as part of this. @rgarner has wanted a sort of global search for a while too, which also factors into the navigation problem. |
jamiecobbett
added a commit
that referenced
this pull request
Apr 14, 2014
Create a go to mapping modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.