Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a go to mapping modal #253

Merged
merged 3 commits into from Apr 14, 2014
Merged

Create a go to mapping modal #253

merged 3 commits into from Apr 14, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 11, 2014

  • When pressing “g m” a modal appears asking for an old URL, entering the URL will take you directly to that mappings edit screen
  • “g m” for “go to mapping”
  • Uses the existing find_global method to resolve a mapping without site

screen shot 2014-04-11 at 13 44 34

Paul Hayes added 3 commits Apr 11, 2014
Paul Hayes
* When pressing “g m” a modal appears asking for an old URL, entering
the URL will take you directly to that mappings edit screen
* “g m” for “go to mapping”
* Uses the existing find_global method to resolve a mapping without site
Paul Hayes
* There were two “Old URL” fields and the assertion was looking at the
wrong one
* Instead look for “Old URLs”
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Apr 14, 2014

This is neat, but I have a concern here about the lack of discoverability. I had expected us to add a link to open this dialog - is that something you plan to add soon?

@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 14, 2014

You're right that discoverability is a concern, creating a UI or link to the modal is a much bigger problem that I didn't want to solve as part of this. @rgarner has wanted a sort of global search for a while too, which also factors into the navigation problem.

jamiecobbett added a commit that referenced this pull request Apr 14, 2014
Create a go to mapping modal
@jamiecobbett jamiecobbett merged commit 33ac7c3 into master Apr 14, 2014
1 check passed
1 check passed
default "Build #387 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the go-to-pages branch Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.