Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacken Whitehall admin header #1651

Merged
merged 5 commits into from Aug 12, 2014
Merged

Blacken Whitehall admin header #1651

merged 5 commits into from Aug 12, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 11, 2014

  • Bring Whitehall admin header closer inline with other tools using the admin gem
  • Include a more prominent environment bar across the top of the window
  • Code review
  • Product review

Before:
screen shot 2014-08-11 at 16 46 03

After:
screen shot 2014-08-11 at 16 46 33

* Try and match other admin apps a little more, use a darker
background, and lighten the tabs.
@edds
Copy link
Contributor

@edds edds commented Aug 12, 2014

Looks good to me.

@bishboria
Copy link
Contributor

@bishboria bishboria commented Aug 12, 2014

👍

@tekin
Copy link
Contributor

@tekin tekin commented Aug 12, 2014

Let's get this merged! 🍔

fofr added 4 commits Aug 4, 2014
* Match other admin applications
* Clarify name of application
* Match other admin apps with a 5px coloured bar stretching across the
header
* Because of tabs this is at the top of the masthead rather than the
bottom
fofr added a commit that referenced this pull request Aug 12, 2014
Blacken Whitehall admin header
@fofr fofr merged commit 2ae1004 into master Aug 12, 2014
1 check passed
1 check passed
default Build #3784 succeeded on Jenkins
Details
@fofr fofr deleted the dark-header branch Aug 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.