Delete policy groups frontend parts #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fofr
force-pushed
the
delete-policy-working-groups
branch
from
180b063
to
1b53043
Compare
|
Rebased to fix conflicts in |
| @@ -137,6 +137,7 @@ def external_redirect(path_prefix, target) | |||
| resources :ministerial_roles, path: 'ministers', only: [:index, :show], localised: true | |||
| resources :people, only: [:index, :show], localised: true | |||
|
|
|||
| # TODO: Remove `:show` when policy group paths can be otherwise generated | |||
There was a problem hiding this comment.
Is there a 'plan' for this to happen?
There was a problem hiding this comment.
|
👍 Looks good to go to me. |
|
Looks good to me! |
|
👍 |
fofr
changed the title
* Remove styles and view * Simplify show method in controller, leave in place redirect and test * Leave route in place while we need it to generate paths for content * Update associated tests to look for presence of group in index list, but no longer visit the group itself, as that’s no longer served by Whitehall
We can no longer check the rendered policy group from within Whitehall. Corresponding tests are now performed in the publishing API steps here: https://github.com/alphagov/whitehall/blob/19e8c9c4af711a777ed6e16d933d8 e2b8781c70a/test/unit/presenters/publishing_api_presenters/working_group _test.rb#L43-L51
fofr
force-pushed
the
delete-policy-working-groups
branch
from
1b53043
to
4b1d47e
Compare
|
I've rebased and updated to work in combination with #2552
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Holding off merging as the Whitehall rendering is useful in determining the cause of https://trello.com/c/jdXSYAdf/340-bug-policy-group-broken-content
https://trello.com/c/EksTt8uH/254-7-policy-working-group-migration-delete-whitehall-s-frontend-code-deploy-2-small