Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete policy groups frontend parts #2526

Merged
merged 2 commits into from Apr 18, 2016
Merged

Delete policy groups frontend parts #2526

merged 2 commits into from Apr 18, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 24, 2016

Holding off merging as the Whitehall rendering is useful in determining the cause of https://trello.com/c/jdXSYAdf/340-bug-policy-group-broken-content

  • Remove styles, view and controller method
  • Leave route in place while we need it to generate paths for content
  • Update associated tests to look for presence of group in index list, but no longer visit the group itself, as that’s no longer served by Whitehall

https://trello.com/c/EksTt8uH/254-7-policy-working-group-migration-delete-whitehall-s-frontend-code-deploy-2-small

@fofr fofr force-pushed the delete-policy-working-groups branch from 180b063 to 1b53043 Mar 29, 2016
@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 29, 2016

Rebased to fix conflicts in base.scss

@@ -137,6 +137,7 @@ def external_redirect(path_prefix, target)
resources :ministerial_roles, path: 'ministers', only: [:index, :show], localised: true
resources :people, only: [:index, :show], localised: true

# TODO: Remove `:show` when policy group paths can be otherwise generated

This comment has been minimized.

@gpeng

gpeng Mar 30, 2016
Contributor

Is there a 'plan' for this to happen?

@gpeng
Copy link
Contributor

@gpeng gpeng commented Mar 30, 2016

👍 Looks good to go to me.

@tvararu
Copy link
Contributor

@tvararu tvararu commented Mar 30, 2016

Looks good to me!

@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Mar 30, 2016

👍

@fofr fofr changed the title [DO NOT MERGE] Delete policy groups frontend parts Delete policy groups frontend parts Apr 14, 2016
fofr added 2 commits Mar 23, 2016
* Remove styles and view
* Simplify show method in controller, leave in place redirect and test
* Leave route in place while we need it to generate paths for content
* Update associated tests to look for presence of group in index list,
but no longer visit the group itself, as that’s no longer served by
Whitehall
We can no longer check the rendered policy group from within Whitehall.
Corresponding tests are now performed in the publishing API steps here:
https://github.com/alphagov/whitehall/blob/19e8c9c4af711a777ed6e16d933d8
e2b8781c70a/test/unit/presenters/publishing_api_presenters/working_group
_test.rb#L43-L51
@fofr fofr force-pushed the delete-policy-working-groups branch from 1b53043 to 4b1d47e Apr 15, 2016
@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 15, 2016

I've rebased and updated to work in combination with #2552

  • I've left the show method in the controller so it can continue to redirect
  • I've left the controller test for the redirect
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Apr 15, 2016

👍

@fofr fofr merged commit b80f7c2 into master Apr 18, 2016
1 check passed
1 check passed
default Build #8145 succeeded on Jenkins
Details
@fofr fofr deleted the delete-policy-working-groups branch Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.