Remove Consultation presentation #3006
Conversation
| @@ -1,18 +0,0 @@ | |||
| class ConsultationsController < DocumentsController | |||
| def index | |||
| filter_params = params.except(:controller, :action, :format, :_) | |||
There was a problem hiding this comment.
Isn't this still needed? I think it's responsible for this redirect: https://www.gov.uk/government/consultations
There was a problem hiding this comment.
It is. Good spot.
There was a problem hiding this comment.
Should be fixed with 53ddfb7
andrewgarner
force-pushed
the
remove-consultation-templates
branch
from
3217ba6
to
53ddfb7
Compare
andrewgarner
changed the title
|
We can merge this once the 4 unpublishing routes that currently point to whitehall are addressed. |
| @@ -3,16 +3,4 @@ def index | |||
| filter_params = params.except(:controller, :action, :format, :_) | |||
| redirect_to publications_path(filter_params.merge(publication_filter_option: 'consultations')) | |||
There was a problem hiding this comment.
It's a shame to have to leave this in. We could just add the redirect into the router. That might be a bit 'magic' though. Thoughts?
There was a problem hiding this comment.
I'd prefer it to be in the router. That's where I'd go to look for redirects.
There was a problem hiding this comment.
Can we do merging of filter_params in the router? Do we still need to?
There was a problem hiding this comment.
Could we use a prefix route? /government/consultations. That might let the filter params pass through to Whitehall with the explicit routes taking the actual consultation requests to government frontend. Need to check that though as I'm not sure.
There was a problem hiding this comment.
Going to merge this and look to address the index action in a subsequent PR.
Consultations have been migrated and are now rendered by Government Frontend. This removes the frontend code that is no longer needed.
andrewgarner
force-pushed
the
remove-consultation-templates
branch
from
53ddfb7
to
c37c06e
Compare
andrewgarner
changed the title
Reverting #3006 has angered the linter.
Consultations have been migrated and are now rendered by Government Frontend. This removes the frontend code that is no longer needed.
Trello