Remove consultation templates redux #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewgarner
force-pushed
the
remove-consultation-templates-redux
branch
from
bd442e3
to
4f9d5d1
Compare
|
Have you tested locally by creating and previewing a consultation with links? Is it worth putting this on integration to double check? Otherwise looks good to me, will leave @gpeng to approve. |
|
I've not tested locally no, but I'll deploy the branch to integration and do some manual testing. |
andrewgarner
changed the title
6 tasks
andrewgarner
changed the title
|
Tested successfully on integration by creating a consultation with both a new PDF and a HTML attachment and previewing the draft. |
|
Epic work @andrewgarner thanks 👍 |
fofr
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrection of #3006. We now have draft links so we can view draft Consultations in Government Frontend and remove the presentation code from Whitehall.
See also #3067 and Trello