Add tests for reports #6177
Merged
Add tests for reports #6177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2021
Merged
1pretz1
force-pushed
the
add-tests-for-reports
branch
from
93aa1c2
to
b9ab74d
Compare
1pretz1
added a commit
to alphagov/publishing-e2e-tests
that referenced
this pull request
Jun 29, 2021
This task has been renamed in Whitehall [1]. Dependant on: alphagov/whitehall#6177 --- Trello: https://trello.com/c/LCR0Am73/2541-5-enable-continuous-deployment-for-whitehall [1]: alphagov/whitehall#6177
1 task
This was refactored two years ago and doesn't actually run due to [line 13][1] as the `delete` call throws an `ArgumentError` for the `PathName` instance. This hasn't been fixed / noticed in all that time so assume this report is no longer needed. [1]: https://github.com/alphagov/whitehall/blob/7c2c8919a6fc1a4432d7c3caef3c4b1b737779cc/lib/reports/draft_publications_report.rb#L13
1pretz1
force-pushed
the
add-tests-for-reports
branch
from
f16957a
to
cc4ad3e
Compare
ChrisBAshton
reviewed
Jul 2, 2021
1pretz1
force-pushed
the
add-tests-for-reports
branch
2 times, most recently
from
363a057
to
555f951
Compare
This commit also standardises them by: * creating constants to store CSV headers * using the apps tmp directory as it feels more appropriate than the global tmp directory
1pretz1
force-pushed
the
add-tests-for-reports
branch
2 times, most recently
from
57d9a0e
to
68d1598
Compare
|
Thanks for the review @ChrisBAshton! Think I've addressed everything. I was getting some strange behaviour when I was running the rake tests locally (tasks running twice, when only invoked once) and have narrowed it down to the tasks themselves being initialised more than once. I've updated this in the last commit. |
Previously this rake file was quite disorganised with inconsistencies like tasks being in the wrong name space. This commit: * Moves tasks to the correct namespace * Renames some tasks to try and gain some naming consistency * Moves redirect routes and special routes to their own model which will help with testing in the next commit
Adds tests to all (non-dry run) rake tasks. This commit also adds a factory attribute to file attachments which makes them more realistic (accesible = `false` instead of `nil`)
This task is needed to satisfy the e2e tests setup. We can remove it once this is merged, and the e2e tests PR is merged [1]. [1]: alphagov/publishing-e2e-tests#422
Not checking if there are any pre-loaded rake tasks was causing tasks to be initialized twice, resulting in them running twice for every single invocation.
1pretz1
force-pushed
the
add-tests-for-reports
branch
from
68d1598
to
dccacfa
Compare
ChrisBAshton
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for some (of the many) rake tasks. I focused mainly on the Publishing API rake tasks as they were the least tested and high value. There has also been some refactoring to try make navigating and adding new publishing api tasks a bit easier.
Trello:
https://trello.com/c/LCR0Am73/2541-5-enable-continuous-deployment-for-whitehall