Use standard for linting JavaScript #8178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move from standardx to standard configured through `.estlintrc.js`. This updates us to the latest version of standard and opens the door for using prettier in future.
Fix eslint errors resulting from the migration from standardx to standard
dnkrj
force-pushed
the
1653-tech-spike-more-opinionated-es6-rules
branch
from
921813a
to
5b45ab0
Compare
dnkrj
force-pushed
the
1653-tech-spike-more-opinionated-es6-rules
branch
4 times, most recently
from
e65fa1a
to
a8d4695
Compare
dnkrj
force-pushed
the
1653-tech-spike-more-opinionated-es6-rules
branch
from
a8d4695
to
21d987c
Compare
These local workflows allow Whitehall to use standard and in future prettier
dnkrj
force-pushed
the
1653-tech-spike-more-opinionated-es6-rules
branch
from
21d987c
to
7cd3125
Compare
richardTowers
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
May 13, 2024
[standardx](https://github.com/standard/standardx) appears to be a bit... unmaintained. It's pinning us to a pretty old version of eslint, and a few other dependencies. We switched to using eslint in Whitehall in alphagov/whitehall#8178 We should consider rolling this out everywhere. TODO - more details on what dependencies we're stuck on, and the horrible story of the eslint config file format 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
no-varsettinghttps://trello.com/c/p8IqI4zH/1653-tech-spike-more-opinionated-es6-rules