faces, theming, modus

[qzdl]

Hey,

In RDE[1] we are looking to provide a configuration of ement[2] which fits the flavour of the distribution[3], which is largely based on the excellent work of Prot in modus[4].

In these efforts, there is some share of the workload in each project to achieve the best results, with initial commentary on the matter in this issue[5].

from the current version in guix, 0.1-pre-1.c951737, two immediate inconsistencies are present, with the notification and mentions buffer not respecting the format string -- I haven't verified this in the head commit however, as I'm just trying to collect the relevant information in this step -- apologies if this has been addressed already.

I hope the coming works can provide some good for you too :)

Cheers,
Samuel

[1] RDE - https://sr.ht/~abcdw/rde https://lists.sr.ht/~abcdw/rde-devel
[2] RDE mailing list, feature-emacs-ement - https://lists.sr.ht/~abcdw/rde-devel/patches/29208
[3] RDE aesthetics - https://cdn.fosstodon.org/media_attachments/files/106/900/674/950/793/851/original/4b17f03528571ca0.png
[4] modus themes - https://protesilaos.com/emacs/modus-themes https://gitlab.com/protesilaos/modus-themes
[5] modus issue: ement - https://gitlab.com/protesilaos/modus-themes/-/issues/279

[protesilaos]

Hello! Just to note that I added support for ement in the themes. Also included a note in the manual: https://protesilaos.com/emacs/modus-themes#h:8e636056-356c-4ca7-bc78-ebe61031f585.

[ Yes, a value of 6 for ement-room-prism-minimum-contrast is perfectly fine as a default. ]

[alphapapa]

Hi,

Thanks for the heads-up. I looked at the patch thread, and I'd like to mention this first:

Prefer setq, I found the usage of customize interface even from configuration-* packages to be confusing, even for myself :) I think we will switch to setq in other places too.

It is not advised to use setq for defcustom variables; in the very patch proposed there, setq is used with a variable which has a defcustom setter defined, so using setq will not work correctly. See

ement.el/ement-room.el

Line 322 in c951737

(defcustom ement-room-message-format-spec "%S%L%B%r%R%t"

I also read through the issue on the modus-themes repo. Prot mentioned the reply-to highlight face being hard-coded: it is, but that could easily be added as a customization in ement. Feel free to open an issue or PR for that, if you like. And feel free to request any other changes that would help you implement the customization and theming you desire. :)

Thanks for sharing this. And thanks, Prot, for your work, as always.

[protesilaos]

Hello @alphapapa!

On 2022-03-01, 01:27 -0800, alphapapa ***@***.***> wrote: I also read through the issue on the modus-themes repo. Prot mentioned the reply-to highlight face being hard-coded: it is, but that could easily be added as a customization in `ement`.

Regarding the `highlight` face, I don't think the hardcoding is problematic per se. What I did not like about it is the extent of the highlight: it calls too much attention to itself. I don't remember the details right now but I think it would cover the entire message. That is probably fine for one-liners but it feels too strong of an emphasis for longer stretches of text. Rather than focus on the face, perhaps you could keep the `highlight` as-is and instead [optionally] limit its effect to a smaller unit like the username, last line/word/sentence, timestamp... Alternatively, it could have a blink effect similar to those of pulse.el.

Feel free to open an issue or PR for that, if you like. And feel free to request any other changes that would help you implement the customization and theming you desire. :)

I believe @qzdl should take the initiative. I haven't used matrix since then and I don't have actual friends/groups to test things without making it awkward. What do you think?

…

-- Protesilaos Stavrou https://protesilaos.com

[alphapapa]

Hi Prot,

Regarding the highlight face, I don't think the hardcoding is problematic per se. What I did not like about it is the extent of the highlight: it calls too much attention to itself. I don't remember the details right now but I think it would cover the entire message. That is probably fine for one-liners but it feels too strong of an emphasis for longer stretches of text.

Rather than focus on the face, perhaps you could keep the highlight as-is and instead [optionally] limit its effect to a smaller unit like the username, last line/word/sentence, timestamp... Alternatively, it could have a blink effect similar to those of pulse.el.

To be sure we're on the same page: I'm referring to the temporary highlight that's displayed while composing a reply to a message--not the face that's permanently applied to mentions of the local user.

If that's also what you mean, well, I suppose we could offer customizeable functions that would be called to apply highlighting to the replied-to messages, and those could be offered in forms that would highlight the whole message, parts of it, etc.

I believe @qzdl should take the initiative. I haven't used matrix since then and I don't have actual friends/groups to test things without making it awkward.

What do you think?

Sure, anyone who's interested in the ideas is welcome.

[alphapapa]

See also protesilaos/modus-themes#25