Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hammy-toggle not working as expected #11

Closed
Edgaras1 opened this issue Aug 31, 2023 · 5 comments
Closed

hammy-toggle not working as expected #11

Edgaras1 opened this issue Aug 31, 2023 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Edgaras1
Copy link

Description says that 'hammy-toggle Pause or unpause a hammy'. When I call this command while hammy is running I get the list of hammies to choose
image
and when I choose hammy I get "funcall-interactively: Invalid time specification". As far as I understand this command should simply pause/unpause the timer without any other functionality?

@alphapapa
Copy link
Owner

Yes, I haven't used that command in a long time, and it seems to be broken. Thanks for reporting.

@alphapapa alphapapa self-assigned this Sep 1, 2023
@alphapapa alphapapa added the bug Something isn't working label Sep 1, 2023
@alphapapa alphapapa added this to the 0.3 milestone Sep 1, 2023
alphapapa added a commit that referenced this issue Sep 1, 2023
Seems to work, but surely needs more testing.  Also, I wonder what
will happen when it's called on an overdue hammy...

See #11.
@alphapapa
Copy link
Owner

@Edgaras1 Please install the latest version, including that commit, and let me know how it works for you.

@Edgaras1
Copy link
Author

Edgaras1 commented Sep 1, 2023

It's working, but I noticed it breaks '⅓-time' timer if I toggle during its 'work' interval, 'rest' interval gets reset

@alphapapa
Copy link
Owner

Thanks, I'll check on that.

@alphapapa
Copy link
Owner

Should be fixed now. Seems to work correctly. Please let me know if it does for you. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants