Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

Commit

Permalink
remove the implementation of the deprecated class EventDatasetReader
Browse files Browse the repository at this point in the history
  • Loading branch information
TaiSakuma committed Jun 18, 2019
1 parent bdf834f commit 2459fb8
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 254 deletions.
83 changes: 0 additions & 83 deletions alphatwirl/loop/EventsInDatasetReader.py

This file was deleted.

5 changes: 3 additions & 2 deletions alphatwirl/loop/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
from .NullCollector import NullCollector
from .ReaderComposite import ReaderComposite

from .EventsInDatasetReader import EventsInDatasetReader

from .deprecated import CollectorComposite
from .deprecated import EventDatasetReader

from .removed import EventsInDatasetReader

10 changes: 10 additions & 0 deletions alphatwirl/loop/removed.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Tai Sakuma <tai.sakuma@gmail.com>
from alphatwirl.misc.deprecation import _removed

##__________________________________________________________________||
# removed after v0.25.4 (2019-06-18)
@_removed(msg='use EventDatasetReader instead.')
class EventsInDatasetReader(object):
pass

##__________________________________________________________________||
169 changes: 0 additions & 169 deletions tests/unit/loop/test_EventsInDatasetReader.py

This file was deleted.

21 changes: 21 additions & 0 deletions tests/unit/loop/test_removal.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Tai Sakuma <tai.sakuma@gmail.com>
import logging
import pytest

from alphatwirl.loop import EventsInDatasetReader

##__________________________________________________________________||
removed_classes = [EventsInDatasetReader]

@pytest.mark.parametrize('Class', removed_classes)
def test_removed(Class, caplog):
with pytest.raises(RuntimeError):
with caplog.at_level(logging.ERROR):
c = Class()
assert len(caplog.records) == 1
assert caplog.records[0].levelname == 'ERROR'
expected = '{} is removed.'.format(Class.__name__)
assert expected in caplog.records[0].msg

##__________________________________________________________________||

0 comments on commit 2459fb8

Please sign in to comment.