Simple change to the benchmark import description. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change gets the benchmark files to import from the github URL in order to vastly simplify running them. Once the module is obtained using "go get github.com/alphazero/Go-redis" the benchmarks can then be run using: for i in src/github.com/alphazero/Go-redis/bench/* ; do $i done This should make running them a little easier. since it no longer requires setting a GOPATH to make it all work.
|
Thanks but not acceptable. /R |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick change that allows the benchmark files to be run without modifying GOPATH. With this change it should be possible to run the following series of commands
go get github.com/alphazero/Go-redis
echo "requirepass go-redis" | redis-server - &
for i in src/github.com/alphazero/Go-redis/bench/*.go ; do
go run $i
done
kill %1
The idea is to make it super simple to run.
Tested using the above commands.