Add optional slide attribute in revealToggle

Used jQuery to add a slideDown/slideUp animation.
alpheios-project · Jul 7, 2014 · eda9e7d · eda9e7d
1 parent 97aa29c
commit eda9e7d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/app/js/arethusa.core/directives/reveal_toggle.js b/app/js/arethusa.core/directives/reveal_toggle.js
@@ -6,6 +6,8 @@ angular.module('arethusa.core').directive('revealToggle', function() {
     link: function(scope, element, attrs) {
       var tId = attrs.revealToggle;
       var alwaysReveal = attrs.alwaysReveal;
+      var slide = attrs.slide;
+
 
       function el() {
         return angular.element(document.getElementById(tId));
@@ -14,9 +16,11 @@ angular.module('arethusa.core').directive('revealToggle', function() {
       element.bind('click', function() {
         var t = el();
         if (alwaysReveal || t.hasClass('hide')) {
+          if (slide) t.slideDown();
           t.removeClass('hide');
           t.trigger('show-' + tId);
         } else {
+          if (slide) t.slideUp();
           t.addClass('hide');
           t.trigger('hide-' + tId);
         }

diff --git a/spec/arethusa.core/directives/reveal_toggle_spec.js b/spec/arethusa.core/directives/reveal_toggle_spec.js
@@ -4,10 +4,16 @@ describe("revealToggle", function() {
   var element;
   beforeEach(module("arethusa.core"));
 
+  function stubFunctions(obj, functions) {
+    angular.forEach(functions, function(functionName, i) {
+      obj[functionName] = function() {};
+    });
+  }
+
   beforeEach(inject(function($compile, $rootScope) {
     element = angular.element('<p><span reveal-toggle="1"/><target id="1"/></p>');
-    // We're using a jQuery function in this directive!
-    angular.element.prototype.trigger = function() {};
+    // We're using jQuery functions in this directive!
+    stubFunctions(angular.element.prototype, ['trigger', 'slideUp', 'slideDown']);
     $compile(element)($rootScope);
   }));