Add more title options #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First PR so wanted to keep it light :D |
HugoDF
reviewed
Nov 27, 2020
There was a problem hiding this comment.
Happy to merge this.
Couple of comments & since we're adding tests again, it would be good to run them on CI, have a look at https://github.com/alpine-collective/alpinejs-devtools/blob/master/.github/workflows/build.yml#L27
|
Also remembered that we've got a note about this in the README that we should probably update. |
HugoDF
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple more ways to discover a component's title.
Some of these might not fit given they are not standard, but I feel they offer flexibility. I can remove them if no one agrees.
x-title- Let's the user override the title and not have it affect anything else.x-id- Used in the$componenthelper so if it exists, the user has intended it to be an identifieraria-label- Accessibility label so better thanroleThis also pushes
rolebelowx-data(if a function name) asroleis usually pretty generic, while a function name is often a better identifier. Objections?I also added a unit test to check the naming. Visual test passed too.
Not sure how to test the Livewire portion though, or if we event want to.