Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libqmi-dev package to base.yaml #159

Conversation

ToshikiNakamura0412
Copy link

@ToshikiNakamura0412 ToshikiNakamura0412 commented Aug 2, 2023

Please add the following dependency to the rosdep database.

Package name:

libqmi-dev

Package Upstream Source:

https://modemmanager.org/docs/libqmi/

Purpose of using this:

libqmi-dev is required to use ModemManager.

Distro packaging links:

Links to Distribution Packages

Please Add This Package to be indexed in the rosdistro.

ROSDISTRO NAME

The source is here:

https://gitlab.freedesktop.org/mobile-broadband/libqmi

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the rosdep label Aug 2, 2023
@ToshikiNakamura0412 ToshikiNakamura0412 marked this pull request as draft August 2, 2023 07:14
@ToshikiNakamura0412 ToshikiNakamura0412 marked this pull request as ready for review August 2, 2023 07:16
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to add other Linux distros, and send the same changes to the official rosdistro to make it easy to develop on Ubuntu ROS

@ToshikiNakamura0412
Copy link
Author

Thank you for your review.
I will add other Linux distros as well. I will also send the same changes to the official rosdistro.
Should I send the changes to the master of this repository (https://github.com/ros/rosdistro)?

@at-wat
Copy link
Member

at-wat commented Aug 4, 2023

Master branch of this repository isn't used and no need to updated

@ToshikiNakamura0412
Copy link
Author

Sorry... Which repository is the official rosdistro?

@at-wat
Copy link
Member

at-wat commented Aug 5, 2023

Sorry, I meant you don't need to open a PR to the master branch of alpine-ros/rosdistro.
It's better to add libqmi-dev to the master branch of ros/rosdistro as well.

@ToshikiNakamura0412
Copy link
Author

I understand. I'll open a PR to the master branch of ros/rosdistro.
May I close this PR?

@at-wat
Copy link
Member

at-wat commented Aug 7, 2023

If you want to merge the change to alpine-ros/rosdistro before waiting ros/rosdistro, please update this PR.

Or you can send PR only to ros/rosdistro, wait it to be merged, and open an issue titled Merge upstream to trigger merging changes on ros/rosdistro to this repository.
(example: #155)

@ToshikiNakamura0412
Copy link
Author

ToshikiNakamura0412 commented Aug 10, 2023

I also sent a pull request to the official rosdistro (ros#38202).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants