x-collapse not working properly when used with click.away #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimoTod
force-pushed
the
bug/x-collapse-and-click-away
branch
from
2272be1
to
a53c39d
Compare
|
This is perfect(as always) thanks Simone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this change is could be considered as a mild BC.Before this PR an element was considered as 'not visible' if both the outer width and outer height were 0. This was working okay with a standard x-show but with x-collapse, only the height is 0.With this PR, an element is considered as "not visible" even if only one of the 2 is 0. From a human point of view, this makes sense because an element with height = 0 is not really visible. Despite being a behavioural change, I don't think anyone was expecting click away to trigger in this scenario so it won't probably break anything to anyone.Update
The approach above was still not working if the element had borders as the outer height wasn't 0 (borders and paddings are still visible when the element is collapsed, not sure if it's intentional). The new approach just add a special check for
el._x_isShown === false