[WIP] abuild.in: add default bashcomp zshcomp and fishcomp functions #74
Conversation
abuild.in
Outdated
|
|
||
| cd "$pkgdir" || return 0 | ||
| for i in $(find usr/share/bash-completion/completions etc/bash_completion.d -type f 2>/dev/null); do | ||
| install -Dm0644 "$i" "$subpkgdir"/usr/share/bash-completion/completions/"$(basename $i)" |
There was a problem hiding this comment.
Subpackage functions usually use mkdir + mv, like this you end up with a copy in the main package and in the completion package.
This applies to all 3 functions.
abuild.in
Outdated
|
|
||
| cd "$pkgdir" || return 0 | ||
| for i in $(find usr/share/bash-completion/completions etc/bash_completion.d -type f 2>/dev/null); do | ||
| mkdir -p "$subpkgdir"/"${1%/*}" |
There was a problem hiding this comment.
I don't think these functions have positional args, do you perhaps mean:
| mkdir -p "$subpkgdir"/"${1%/*}" | |
| mkdir -p "$subpkgdir"/"${i%/*}" |
|
On Thu, May 02, 2019 at 12:48:08PM -0700, Chloe Kudryavtsev wrote:
5paceToast requested changes on this pull request.
> @@ -1803,6 +1829,53 @@ openrc() {
default_openrc
}
+default_bashcomp() {
+ depends=""
+ pkgdesc="Bash completions for $pkgname"
+ install_if="$pkgname=$pkgver-r$pkgrel bash-completion"
+
+ cd "$pkgdir" || return 0
+ for i in $(find usr/share/bash-completion/completions etc/bash_completion.d -type f 2>/dev/null); do
+ mkdir -p "$subpkgdir"/"${1%/*}"
I don't think these functions have positional args, do you perhaps mean:
```suggestion
mkdir -p "$subpkgdir"/"${i%/*}"
```
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#74 (review)
yes
|
|
On Thu, May 02, 2019 at 08:05:32PM +0000, Chloe Kudryavtsev wrote:
5paceToast approved this pull request.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#74 (review)
I pushed a few changes ( using install + rm -rf ), please re-check
|
|
@5paceToast please check again i decided to use |
|
I think this should wait for the |
|
Ok i'll put this as WIP |
maxice8
changed the title
|
amove() is in, i'll update add this to gitlab |
|
Merged in d582696 by @ncopa. Thanks for your contribution! (This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.) |
|
docker cant does not run: please can somebody help me on how to make docker run on my system. After carefully following the instruction on installing docker on alpine page and installed it on my system, each time i start docker i see the following error: Server: |
1 similar comment
|
docker cant does not run: please can somebody help me on how to make docker run on my system. After carefully following the instruction on installing docker on alpine page and installed it on my system, each time i start docker i see the following error: Server: |
|
@ichit This isn't really the place for reports on Docker not running -- you'd be best to go through Docker support channels (their Github etc). However, by the sounds of it you may need to add your user account to the |
No description provided.