New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main/xen: build EFI binaries #1513

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@radhus
Contributor

radhus commented May 15, 2017

New binutils 2.28-r2 provides the x86_64-pep target which makes Xen
build its EFI bootloader.

The EFI binaries are placed in /boot and provided by xen-hypervisor:
/boot/xen-4.8.1.efi
/boot/xen-4.8.efi
/boot/xen-4.efi
/boot/xen.efi

@radhus

This comment has been minimized.

Show comment
Hide comment
@radhus

radhus May 15, 2017

Contributor

@kaniini Here's the second one.

It seems like it makes most sense to place them in /boot and thus in the xen-hypervisor package, this is like Debian I think. But if you believe that is a more intruding change before the release, maybe I can redo with a xen-efi package instead, and perhaps in the original /usr/lib64/efi location?

Contributor

radhus commented May 15, 2017

@kaniini Here's the second one.

It seems like it makes most sense to place them in /boot and thus in the xen-hypervisor package, this is like Debian I think. But if you believe that is a more intruding change before the release, maybe I can redo with a xen-efi package instead, and perhaps in the original /usr/lib64/efi location?

@jirutka jirutka added the A-improve label May 15, 2017

@jirutka jirutka requested a review from ncopa May 15, 2017

@kaniini

This comment has been minimized.

Show comment
Hide comment
@kaniini

kaniini May 16, 2017

Contributor

I'm not sure it is appropriate to install them to /boot, shouldn't it be installed to a standard EFI location?

Contributor

kaniini commented May 16, 2017

I'm not sure it is appropriate to install them to /boot, shouldn't it be installed to a standard EFI location?

@radhus

This comment has been minimized.

Show comment
Hide comment
@radhus

radhus May 16, 2017

Contributor

Yes, you are right. Correct me if I'm wrong, but I don't think we have anything like that in Alpine yet?

Packages with EFI binaries that I've looked at now seem to store them in /usr somewhere, like:

  • gummiboot with /usr/lib/gummiboot/gummibootx64.efi
  • syslinux with /usr/share/syslinux/efi64/syslinux.efi

Do you think it would be viable to keep them in /usr/lib64/efi for now, but perhaps in the xen-hypervisor package? It would be nice to get the binaries in place for 3.6, and then maybe pursue a general "EFI boot support" feature?

Contributor

radhus commented May 16, 2017

Yes, you are right. Correct me if I'm wrong, but I don't think we have anything like that in Alpine yet?

Packages with EFI binaries that I've looked at now seem to store them in /usr somewhere, like:

  • gummiboot with /usr/lib/gummiboot/gummibootx64.efi
  • syslinux with /usr/share/syslinux/efi64/syslinux.efi

Do you think it would be viable to keep them in /usr/lib64/efi for now, but perhaps in the xen-hypervisor package? It would be nice to get the binaries in place for 3.6, and then maybe pursue a general "EFI boot support" feature?

@radhus

This comment has been minimized.

Show comment
Hide comment
@radhus

radhus May 16, 2017

Contributor

Btw, looks like Travis terminates the job due to exceeding the log limit of 4MB...

Contributor

radhus commented May 16, 2017

Btw, looks like Travis terminates the job due to exceeding the log limit of 4MB...

@kaniini

This comment has been minimized.

Show comment
Hide comment
@kaniini

kaniini Jun 8, 2017

Contributor

@radhus yes that is fine.

i am still working out the details on formal EFI support in alpine as it's kind of complicated. so lets use /usr/lib/efi for now.

Contributor

kaniini commented Jun 8, 2017

@radhus yes that is fine.

i am still working out the details on formal EFI support in alpine as it's kind of complicated. so lets use /usr/lib/efi for now.

@radhus

This comment has been minimized.

Show comment
Hide comment
@radhus

radhus Jun 9, 2017

Contributor

@kaniini Ok, cool, I'll try to push that asap.

If you want help with the EFI support, I can help out with testing and development, just let me know if there's something I can work on. I will be running at least some boxes now with Xen that I will boot from EFI.

Contributor

radhus commented Jun 9, 2017

@kaniini Ok, cool, I'll try to push that asap.

If you want help with the EFI support, I can help out with testing and development, just let me know if there's something I can work on. I will be running at least some boxes now with Xen that I will boot from EFI.

@radhus

This comment has been minimized.

Show comment
Hide comment
@radhus

radhus Jul 1, 2017

Contributor

Alright, finally, now it's in /usr/lib64/efi

If this is accepted, is there any chance this might get backported to 3.6 stable? :)
Since it's just inclusion of already built files so I feel it's quite a minor change.

Contributor

radhus commented Jul 1, 2017

Alright, finally, now it's in /usr/lib64/efi

If this is accepted, is there any chance this might get backported to 3.6 stable? :)
Since it's just inclusion of already built files so I feel it's quite a minor change.

@jirutka

This comment has been minimized.

Show comment
Hide comment
@jirutka

jirutka Jul 1, 2017

Member

Alright, finally, now it's in /usr/lib64/efi

That’s wrong, we don’t use /usr/lib64, it should be in /usr/lib.

Member

jirutka commented Jul 1, 2017

Alright, finally, now it's in /usr/lib64/efi

That’s wrong, we don’t use /usr/lib64, it should be in /usr/lib.

@radhus

This comment has been minimized.

Show comment
Hide comment
@radhus

radhus Jul 1, 2017

Contributor

Ah yes, sorry. And I seem to have missed committing the CARCH check for x86_64, sorry. Wait just a minute :)

Contributor

radhus commented Jul 1, 2017

Ah yes, sorry. And I seem to have missed committing the CARCH check for x86_64, sorry. Wait just a minute :)

main/xen: build EFI binaries
New binutils 2.28-r2 provides the x86_64-pep target which makes Xen
build its EFI bootloader.

The EFI binaries are placed in the xen-hypervisor package, which stores
them under /usr/lib/efi.

To use and configure, see https://wiki.xenproject.org/wiki/Xen_EFI
@radhus

This comment has been minimized.

Show comment
Hide comment
@radhus

radhus Jul 1, 2017

Contributor

@jirutka fixed now :)

Contributor

radhus commented Jul 1, 2017

@jirutka fixed now :)

@radhus

This comment has been minimized.

Show comment
Hide comment
@radhus

radhus Aug 7, 2017

Contributor

Let me know if you want to do it any other way, I'm running one physical box with this now and have it verified working with Virtualbox UEFI VM's (although in both cases, you need to configure bootloader (like gummiboot) yourself of course).

Contributor

radhus commented Aug 7, 2017

Let me know if you want to do it any other way, I'm running one physical box with this now and have it verified working with Virtualbox UEFI VM's (although in both cases, you need to configure bootloader (like gummiboot) yourself of course).

@radhus

This comment has been minimized.

Show comment
Hide comment
@radhus

radhus Aug 24, 2017

Contributor

Btw, looks like /usr/lib64/efi/xen-4.8.1.efi is created in the xen packages now, both in 4.8.x and 4.9. Not really what we want I guess.

@jirutka do you have any pointers on how to proceed with this? I can of course rebase it if it's fine as it is.

Contributor

radhus commented Aug 24, 2017

Btw, looks like /usr/lib64/efi/xen-4.8.1.efi is created in the xen packages now, both in 4.8.x and 4.9. Not really what we want I guess.

@jirutka do you have any pointers on how to proceed with this? I can of course rebase it if it's fine as it is.

@radhus radhus closed this Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment