-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing/gist: new aport #4272
testing/gist: new aport #4272
Conversation
testing/gist/APKBUILD
Outdated
python3 setup.py install --prefix=/usr --root="$pkgdir" | ||
|
||
# remove unneeded files | ||
rm $pkgdir/usr/share/$pkgname/LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should quote $pkgdir
otherwise this rm
breaks when the absolute path contains a space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
testing/gist/APKBUILD
Outdated
# Contributor: Sascha Paunovic <azarus@posteo.net> | ||
# Maintainer: Sascha Paunovic <azarus@posteo.net> | ||
pkgname="gist" | ||
_pkgname="python-gist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider: _pkgname="python-$pkgname"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
testing/gist/APKBUILD
Outdated
arch="noarch" | ||
license="MIT" | ||
depends="python3" | ||
makedepends="python3-dev py-setuptools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
py-setuptools
is for python2, it should not be needed for python3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, you're right. Will adjust the commit.
https://github.com/jdowner/gist gist command line interface
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be automatically closed if no further activity occurs in the next 14 days. If you are still waiting for a review or response from one of our developers you can leave a comment to remove the stale label. If you know the username of the maintainer of the aport you could try to mention the username in the comment. You can also join our IRC channels on freenode and see if you can find an available developer. Thank you for your contributions. |
This pull request has been automatically closed. |
Can't be merged, depends on unpackaged python-gnupg |
https://github.com/jdowner/gist
gist command line interface